Add Route 53 zone and record for design.vy.no domain#1959
Draft
tomarnebra wants to merge 2 commits intomainfrom
Draft
Add Route 53 zone and record for design.vy.no domain#1959tomarnebra wants to merge 2 commits intomainfrom
tomarnebra wants to merge 2 commits intomainfrom
Conversation
|
Contributor
Terraform Plan for Test 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# module.app.aws_route53_record.design_vy_no will be created
+ resource "aws_route53_record" "design_vy_no" {
+ allow_overwrite = (known after apply)
+ fqdn = (known after apply)
+ id = (known after apply)
+ name = "test.design.vy.no"
+ records = [
+ "designmanual.test.vylabs.io",
]
+ ttl = 300
+ type = "CNAME"
+ zone_id = (known after apply)
}
# module.app.aws_route53_zone.design_vy_no will be created
+ resource "aws_route53_zone" "design_vy_no" {
+ arn = (known after apply)
+ comment = "Managed by Terraform"
+ force_destroy = false
+ id = (known after apply)
+ name = "design.vy.no"
+ name_servers = (known after apply)
+ primary_name_server = (known after apply)
+ tags_all = {
+ "application" = "digitalekanaler-designmanual"
+ "repo" = "spor"
+ "terraform" = "true"
}
+ zone_id = (known after apply)
}
Plan: 2 to add, 0 to change, 0 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit e6db58e |
Contributor
Terraform Plan for Stage 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# module.app.aws_route53_record.design_vy_no will be created
+ resource "aws_route53_record" "design_vy_no" {
+ allow_overwrite = (known after apply)
+ fqdn = (known after apply)
+ id = (known after apply)
+ name = "stage.design.vy.no"
+ records = [
+ "designmanual.stage.vylabs.io",
]
+ ttl = 300
+ type = "CNAME"
+ zone_id = (known after apply)
}
# module.app.aws_route53_zone.design_vy_no will be created
+ resource "aws_route53_zone" "design_vy_no" {
+ arn = (known after apply)
+ comment = "Managed by Terraform"
+ force_destroy = false
+ id = (known after apply)
+ name = "design.vy.no"
+ name_servers = (known after apply)
+ primary_name_server = (known after apply)
+ tags_all = {
+ "application" = "digitalekanaler-designmanual"
+ "repo" = "spor"
+ "terraform" = "true"
}
+ zone_id = (known after apply)
}
Plan: 2 to add, 0 to change, 0 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit e6db58e |
Contributor
Terraform Plan for Production 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# module.app.aws_route53_record.design_vy_no will be created
+ resource "aws_route53_record" "design_vy_no" {
+ allow_overwrite = (known after apply)
+ fqdn = (known after apply)
+ id = (known after apply)
+ name = "design.vy.no"
+ records = [
+ "designmanual.vylabs.io",
]
+ ttl = 300
+ type = "CNAME"
+ zone_id = (known after apply)
}
# module.app.aws_route53_zone.design_vy_no will be created
+ resource "aws_route53_zone" "design_vy_no" {
+ arn = (known after apply)
+ comment = "Managed by Terraform"
+ force_destroy = false
+ id = (known after apply)
+ name = "design.vy.no"
+ name_servers = (known after apply)
+ primary_name_server = (known after apply)
+ tags_all = {
+ "application" = "digitalekanaler-designmanual"
+ "repo" = "spor"
+ "terraform" = "true"
}
+ zone_id = (known after apply)
}
Plan: 2 to add, 0 to change, 0 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit e6db58e |
Contributor
Author
|
.deploy test |
Contributor
Deployment Triggered 🚀tomarnebra, started a branch deployment to Test (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "Test",
"url": null
},
"deployment": {
"timestamp": "2025-10-16T11:23:21.830Z",
"logs": "https://github.com/nsbno/spor/actions/runs/18559618287"
},
"git": {
"branch": "design-subdomain",
"commit": "e6db58eb756a853303e85a474482126e423eda53",
"verified": true,
"committer": "tomarnebra",
"html_url": "https://github.com/nsbno/spor/commit/e6db58eb756a853303e85a474482126e423eda53"
},
"context": {
"actor": "tomarnebra",
"noop": false,
"fork": false,
"comment": {
"created_at": "2025-10-16T11:23:04Z",
"updated_at": "2025-10-16T11:23:04Z",
"body": ".deploy test",
"html_url": "https://github.com/nsbno/spor/pull/1959#issuecomment-3410400929"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Contributor
Deployment Results ✅tomarnebra successfully deployed branch |
Contributor
Terraform Plan for Stage 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# module.app.aws_route53_record.design_vy_no will be created
+ resource "aws_route53_record" "design_vy_no" {
+ allow_overwrite = (known after apply)
+ fqdn = (known after apply)
+ id = (known after apply)
+ name = "stage.design.vy.no"
+ records = [
+ "designmanual.stage.vylabs.io",
]
+ ttl = 300
+ type = "CNAME"
+ zone_id = (known after apply)
}
# module.app.aws_route53_zone.design_vy_no will be created
+ resource "aws_route53_zone" "design_vy_no" {
+ arn = (known after apply)
+ comment = "Managed by Terraform"
+ force_destroy = false
+ id = (known after apply)
+ name = "stage.design.vy.no"
+ name_servers = (known after apply)
+ primary_name_server = (known after apply)
+ tags_all = {
+ "application" = "digitalekanaler-designmanual"
+ "repo" = "spor"
+ "terraform" = "true"
}
+ zone_id = (known after apply)
}
Plan: 2 to add, 0 to change, 0 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit 35c720c |
Contributor
Terraform Plan for Test 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.app.aws_route53_record.design_vy_no must be replaced
-/+ resource "aws_route53_record" "design_vy_no" {
+ allow_overwrite = (known after apply)
~ fqdn = "test.design.vy.no" -> (known after apply)
~ id = "Z073886326GV5R5CSR046_test.design.vy.no_CNAME" -> (known after apply)
- multivalue_answer_routing_policy = false -> null
name = "test.design.vy.no"
~ zone_id = "Z073886326GV5R5CSR046" -> (known after apply) # forces replacement
# (5 unchanged attributes hidden)
}
# module.app.aws_route53_zone.design_vy_no must be replaced
-/+ resource "aws_route53_zone" "design_vy_no" {
~ arn = "arn:aws:route53:::hostedzone/Z073886326GV5R5CSR046" -> (known after apply)
~ id = "Z073886326GV5R5CSR046" -> (known after apply)
~ name = "design.vy.no" -> "test.design.vy.no" # forces replacement
~ name_servers = [
- "ns-1116.awsdns-11.org",
- "ns-1939.awsdns-50.co.uk",
- "ns-464.awsdns-58.com",
- "ns-912.awsdns-50.net",
] -> (known after apply)
~ primary_name_server = "ns-464.awsdns-58.com" -> (known after apply)
- tags = {} -> null
~ zone_id = "Z073886326GV5R5CSR046" -> (known after apply)
# (4 unchanged attributes hidden)
}
Plan: 2 to add, 0 to change, 2 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit 35c720c |
Contributor
Terraform Plan for Production 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# module.app.aws_route53_record.design_vy_no will be created
+ resource "aws_route53_record" "design_vy_no" {
+ allow_overwrite = (known after apply)
+ fqdn = (known after apply)
+ id = (known after apply)
+ name = "design.vy.no"
+ records = [
+ "designmanual.vylabs.io",
]
+ ttl = 300
+ type = "CNAME"
+ zone_id = (known after apply)
}
# module.app.aws_route53_zone.design_vy_no will be created
+ resource "aws_route53_zone" "design_vy_no" {
+ arn = (known after apply)
+ comment = "Managed by Terraform"
+ force_destroy = false
+ id = (known after apply)
+ name = "design.vy.no"
+ name_servers = (known after apply)
+ primary_name_server = (known after apply)
+ tags_all = {
+ "application" = "digitalekanaler-designmanual"
+ "repo" = "spor"
+ "terraform" = "true"
}
+ zone_id = (known after apply)
}
Plan: 2 to add, 0 to change, 0 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit 35c720c |
Contributor
Author
|
.deploy test |
Contributor
Deployment Triggered 🚀tomarnebra, started a branch deployment to Test (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "Test",
"url": null
},
"deployment": {
"timestamp": "2025-10-16T11:39:40.413Z",
"logs": "https://github.com/nsbno/spor/actions/runs/18560023119"
},
"git": {
"branch": "design-subdomain",
"commit": "35c720cb590870fa8e4301c1c01eb611bca94645",
"verified": true,
"committer": "tomarnebra",
"html_url": "https://github.com/nsbno/spor/commit/35c720cb590870fa8e4301c1c01eb611bca94645"
},
"context": {
"actor": "tomarnebra",
"noop": false,
"fork": false,
"comment": {
"created_at": "2025-10-16T11:39:24Z",
"updated_at": "2025-10-16T11:39:24Z",
"body": ".deploy test",
"html_url": "https://github.com/nsbno/spor/pull/1959#issuecomment-3410458669"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Contributor
Deployment Results ❌tomarnebra had a failure when deploying |
cibietici
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Closes #
Solution
General Checklist
Accessibility checklist
For changes impacting the user interface or functionality, ensure the following:
Screenshots