Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
背景
#386 の修正で
defaultValue: 'claude'を削除し、movement-level provider が正しく優先されるようになった。しかし、provider の解決ロジックが2箇所に分かれている構造自体は残っている。
現状
pieceExecution.ts:558resolveMovementProviderModel()runner.ts:32-37resolveProviderModelCandidates()両者は同じ優先順位を意図しているが、独立した実装のため将来的にズレるリスクがある。
提案
AgentRunner.resolveProviderAndModel()を static public にし、pieceExecution.tsの表示側からも同じメソッドを呼ぶようにする。これにより「表示された provider = 実行に使われる provider」が構造的に保証される。
Execution Report
Piece
defaultcompleted successfully.Closes #390