Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
背景
quality_gatesは現在ピースYAMLのムーブメント定義でしか指定できない。しかしnpm run test:e2eのようなプロジェクト固有の検証要件は builtin ピースに埋め込むべきではない。実例:
default-test-first-miniピースで TAKT 本体を開発した際、implement/supervise がnpm run test:e2eを実行せず CI が失敗した。提案
プロジェクト config (
.takt/config.yaml) およびグローバル config (~/.takt/config.yaml) でquality_gatesをオーバーライドできるようにする。解決順(優先度高→低)
.takt/config.yamlのpiece_overrides~/.takt/config.yamlのpiece_overrides設定例
ムーブメント名指定も検討:
マージ戦略
quality_gatesは 追加マージ(ピースYAML の gates + config の gates)edit: trueのムーブメントのみに限定するオプションも検討関連
src/infra/config/loaders/pieceParser.ts— 現在の quality_gates パースsrc/core/piece/instruction/InstructionBuilder.ts— quality_gates インジェクションsrc/infra/config/project/projectConfig.ts— プロジェクト configsrc/infra/config/global/globalConfig.ts— グローバル configExecution Report
Piece
defaultcompleted successfully.Closes #382