Un-deprecate sign(), change naming sign_with_ref()#46
Merged
Conversation
Made Identity hold Box<Cow<>> instances for its variants instead of just Box<>, which enables holding a reference when that is what you pass in, avoiding needless copying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made Identity hold Box<Cow<>> instances for its variants instead of just Box<>, which enables holding a reference when that is what you pass in, avoiding needless copying.
I realised that most users of the signing API would probably just hold either a PublicKey or a Certificate, in which case the sign() signature makes complete sense. Calling it with a &PublicKey or &Certificate will do the right thing, and the cost of creating an Identity instance presumably very small. For the case where some calling code holds an Identity, it makes sense that one might not want that Identity to be needlessly moved into sign(), so for this case a separate method
sign_with_ref()makes sense so that this value can be borrowed.