Ensure we are only initializing logging once#70
Merged
Conversation
Previously, when sm_authenticate() is called mulitple times, there would be a warning stating that logging initalizaion could only happen once. Now, we hold a Mutex<bool> that ensures that it only gets called once and in the unlikely event that tehre are concurrent calls to init_logging() that only one thread wins and gets to attempt initialization
Owner
Author
|
This problem would be visible for anyone that used pam-ssh-agent with sudo with the default configuration but where for example none of the keys available from ssh-agent would be present in /etc/security/authorized_keys, as sudo then would try to authenticate three times in rapid succession. I have tested this manually on a linux box and it does indeed resolve that problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when sm_authenticate() is called mulitple times, there would be a warning stating that logging initalizaion could only happen once. Now, we hold a Mutex that ensures that it only gets called once and in the unlikely event that tehre are concurrent calls to init_logging() that only one thread wins and gets to attempt initialization