Don't decode query params in a valid URI

BrowseRouter/Model/UriFactory.cs

@@ -4,16 +4,11 @@ namespace BrowseRouter.Model;
 
 public static class UriFactory
 {
-  public static Uri Get(string url)
+  public static Uri? Get(string url) => url switch
   {
-    try
-    {
-      return new Uri(WebUtility.UrlDecode(url));
-    }
-    catch (UriFormatException)
-    {
-      // Try to prepend https when given an incomplete URI e.g. "google.com"
-      return new Uri($"https://{url}");
-    }
-  }
+    _ when Uri.TryCreate(url, UriKind.Absolute, out var uri) => uri,
+    _ when Uri.TryCreate($"https://{url}", UriKind.Absolute, out var uri) => uri,
+    _ when Uri.TryCreate(WebUtility.UrlDecode(url), UriKind.Absolute, out var uri) => uri,
+    _ => null,
+  };
 }

BrowseRouter/Services/BrowserService.cs

@@ -26,7 +26,14 @@ public async Task LaunchAsync(string rawUrl, string windowTitle)
 
       IEnumerable<UrlPreference> urlPreferences = config.GetUrlPreferences(ConfigType.Urls);
       IEnumerable<UrlPreference> sourcePreferences = config.GetUrlPreferences(ConfigType.Sources);
-      Uri uri = UriFactory.Get(url);
+      Uri? uri = UriFactory.Get(url);
+
+      if (uri is null)
+      {
+        Log.Write($"Invalid URL: {url}");
+        await notifier.NotifyAsync("Error", $"Invalid URL: {url}");
+        return;
+      }
 
       UrlPreference? pref = null;
       if (sourcePreferences.TryGetPreference(windowTitle, out UrlPreference sourcePref))

BrowseRouter/config.ini

@@ -11,9 +11,9 @@ ff = %ProgramFiles%\Mozilla Firefox\firefox.exe
 chrome = %ProgramFiles%\Google\Chrome\Application\chrome.exe
 
 [urls]
-*.google.com = chrome
-*.visualstudio.com = edge
-*.mozilla.org = ff
+*google.com = chrome
+*microsoft.com = edge
+*mozilla.org = ff
 
 [sources]
 *Microsoft Teams* = edge

BrowseRouter/config.json

@@ -8,9 +8,9 @@
     "enabled": true
   },
   "urls": {
-    "*.google.com": "chrome",
-    "*.visualstudio.com": "edge",
-    "*.mozilla.org": "ff"
+    "*google.com": "chrome",
+    "*microsoft.com": "edge",
+    "*mozilla.org": "ff"
   },
   "browsers": {
     "edge": "%ProgramFiles(x86)%\\Microsoft\\Edge\\Application\\msedge.exe",

Directory.Build.props

@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <LangVersion>latest</LangVersion>
-    <Version>0.15.6</Version>
+    <Version>0.16.0</Version>
     <Product>BrowseRouter</Product>
     <Copyright>EnduraByte LLC 2025</Copyright>
     <!-- Reduces flagging as malware -->

Tests/BrowseRouter.Tests/Model/ArgsTests/FormatMethod.cs

@@ -0,0 +1,14 @@
+using BrowseRouter.Model;
+
+namespace BrowseRouter.Tests.Model.ArgsTests;
+
+public class FormatMethod
+{
+  [Fact]
+  public void DoesNotDecodeQueryString()
+  {
+    string result = Args.Format("", new Uri("https://www.google.com/search?q=C%23+Rocks"));
+
+    result.Should().NotContain("C# Rocks");
+  }
+}

Tests/BrowseRouter.Tests/Model/UriFactoryTests.cs

@@ -8,26 +8,45 @@ public class GetMethod
   public void HandlesValidUrl()
   {
     string url = "https://www.example.com/path";
-    var act = () => UriFactory.Get(url);
+    var uri = UriFactory.Get(url);
 
-    act.Should().NotThrow<UriFormatException>();
+    uri?.AbsoluteUri.Should().Be("https://www.example.com/path");
   }
 
   [Fact]
-  public void HandlesUrlWithoutHttps()
+  public void PrependsHttps_ForUrlWithoutScheme()
   {
     string url = "www.example.com/path";
-    var act = () => UriFactory.Get(url);
+    var uri = UriFactory.Get(url);
 
-    act.Should().NotThrow<UriFormatException>();
+    uri?.Scheme.Should().Be("https");
+    uri?.AbsoluteUri.Should().Be("https://www.example.com/path");
   }
 
   [Fact]
-  public void HandlesUrlEncodedUrl()
+  public void DecodesUrlEncodedUrl()
   {
-    string url = "https%3A%2F%2Fwww.example.com%2Fpath%2F";
-    var act = () => UriFactory.Get(url);
+    string url = "https%3A%2F%2Fwww.example.com%2Fpath";
+    var uri = UriFactory.Get(url);
 
-    act.Should().NotThrow<UriFormatException>();
+    uri?.AbsoluteUri.Should().Be("https://www.example.com/path");
+  }
+
+  [Fact]
+  public void PreservesQueryParameters()
+  {
+    string url = "https://www.example.com/path?token=6Us%2btD%2btWmVr";
+    var uri = UriFactory.Get(url);
+
+    uri?.Query.Should().Be("?token=6Us%2btD%2btWmVr");
+  }
+
+  [Fact]
+  public void ReturnsNull_ForInvalidUrl()
+  {
+    string url = "";
+    var uri = UriFactory.Get(url);
+
+    uri.Should().BeNull();
   }
 }