Skip to content

329 add elevation and azimuth information on txt outputs#330

Merged
vsmagalhaes merged 74 commits intoastrohack-devfrom
329-add-elevation-and-azimuth-information-on-txt-outputs
Jul 3, 2025
Merged

329 add elevation and azimuth information on txt outputs#330
vsmagalhaes merged 74 commits intoastrohack-devfrom
329-add-elevation-and-azimuth-information-on-txt-outputs

Conversation

@vsmagalhaes
Copy link
Copy Markdown
Collaborator

@vsmagalhaes vsmagalhaes commented Jul 3, 2025

This pull request brings a few innovations:

  • There is now a observation summary attached to each holography xds.
  • This summary can be printed and exported to an ASCII file through a method called .observation_summary
  • This allows for the decoupling of imaging characteristics between DDIs
  • Added a Z scale control to the image_compare_tool.
  • However backward file compatibility has been broken.
  • Hence a check if the file can be opened has been implemented.

vsmagalhaes added 30 commits June 23, 2025 15:06
@vsmagalhaes
improved docstring
898517c
@vsmagalhaes
improved docstring
1f3123c
@vsmagalhaes
Renamed import that was named as a single letter.
f1242ed
@vsmagalhaes
holog_mds now stores an AZ EL summary.
211c3d9
@vsmagalhaes
holog now propagates AZ EL summary.
df4dd35
@vsmagalhaes
panel now propagates AZ EL summary.
9c4be17
@vsmagalhaes
Az El is now left in radians for convenient conversion at output. fur…
3c0c86d 
…ther restriction on fetch position of center limiting to the middle of the observation.
@vsmagalhaes
Created a routine to format Az El information.
5f33100
@vsmagalhaes
extract_holog.py now extracts and stores an observation summary.
26bc96d
@vsmagalhaes
holog.py now propagates observation information
94fd2ac
@vsmagalhaes
panel now propagates observation information
09bf00d
@vsmagalhaes
extract_holog.py now stores a summary of frequency information.
0f409f2
@vsmagalhaes
holog now propagates summary of frequency information.
7a5803a
@vsmagalhaes
panel now propagates summary of frequency information.
542a588
@vsmagalhaes
Fixed right ascension negative values
dd2a2a5
@vsmagalhaes
Added routine to format observation summary
0c5f144
@vsmagalhaes
Added routine to format spectral summary
90fbba7
@vsmagalhaes
cosmetic alignment.
2480f1e
@vsmagalhaes
calculate_optimal_grid_parameters now outputs len 2 arrays rather tha…
c1b9d9f 
…n single values for both directions.
@vsmagalhaes
short term fix.
f0fff58
@vsmagalhaes
implemented a more complete summary information dictionary.
4cd8062
@vsmagalhaes
small change caused by key name change
a6f2c97
@vsmagalhaes
Aggressively removing holog_mds meta data as it is heavily superseded…
c77a87b 
… by the new observation summary.
@vsmagalhaes
improved message
a7c6275
@vsmagalhaes
Brought back writting of holog_json.
0d69f60
@vsmagalhaes
some reorganization.
9e1bd21
@vsmagalhaes
Corrected a typo
1b6e8bf
@vsmagalhaes
holog now uses the data in the summary and passes it along.
5930210
@vsmagalhaes
grid size is now a list of integers from the get go
f69d14d
@vsmagalhaes
panel now uses the summary functionality.
3ae695e
vsmagalhaes added 21 commits July 2, 2025 14:38
@vsmagalhaes
Az el key default is now center.
93d3d89
@vsmagalhaes
Added a function to check if file can be opened.
ff93e79
@vsmagalhaes
Fixed a bug in the labelling of panels.
f564326
@vsmagalhaes
Added .point_input, improved error message.
b540d0b
@vsmagalhaes
Extract_holog now checks if the point file can be opened.
96c3177
@vsmagalhaes
panel now checks if the image file can be opened.
6e51ffd
@vsmagalhaes
holog now checks if the holog file can be opened.
dbe0472
@vsmagalhaes
Locit can now check if locit file can be opened.
f074124
@vsmagalhaes
Open functions now check if they can open a file.
5098361
@vsmagalhaes
fixed circular import in locit.py
6362293
@vsmagalhaes
fixed circular import in holog.py
775058c
@vsmagalhaes
Low confidence fix to panel.
1bb7a2b
@vsmagalhaes
Corrected the fact that the L cell size must be negative. Also protec…
4b75a6d 
…ted against cell size and grid size being given as lists.
@vsmagalhaes
Fixed definition RingPanel center.
ab13a35
@vsmagalhaes
Fixed VLA stakeholder by fixing the grid and cell sizes. Also removed…
0fa8d03 
… a test that is no longer relevant as the correspondent Attr file no longer exists.
@vsmagalhaes
Fixed antenna class tests by reverting to previous values.
2ba1973
@vsmagalhaes
calculate_optimal_grid_parameters now guarantees that L and M axes wi…
ea5b91f 
…ll have the same size, this is done to warrant that padding will work properly and the same way with both axes.
@vsmagalhaes
Fixed holog tests by explicitly defining the grid and beam sizes to a…
7b74760 
…ssure that the reference values are valid.
@vsmagalhaes
holog now updates the beam section of the summary when gridding the b…
9bb5745 
…eam.
@vsmagalhaes
Added tests on open_position and open_locit
dbb7589
@vsmagalhaes
Black compliance.
0c5c912
@vsmagalhaes vsmagalhaes added this to the VLA Support milestone Jul 3, 2025
@vsmagalhaes vsmagalhaes self-assigned this Jul 3, 2025
@vsmagalhaes vsmagalhaes added enhancement New feature or request visualization Issues regarding visualization labels Jul 3, 2025
@vsmagalhaes vsmagalhaes linked an issue Jul 3, 2025 that may be closed by this pull request
Add Elevation and Azimuth information on txt outputs #329
Closed
@vsmagalhaes vsmagalhaes added the Area:SciDev Science Feature development,validation, bugfix label Jul 3, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 48.99135% with 177 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/astrohack/utils/text.py 9.02% 121 Missing ⚠️
src/astrohack/mds.py 19.35% 25 Missing ⚠️
src/astrohack/core/extract_holog.py 90.27% 7 Missing ⚠️
src/astrohack/core/holog.py 84.61% 4 Missing ⚠️
src/astrohack/core/image_comparison_tool.py 0.00% 4 Missing ⚠️
src/astrohack/utils/validation.py 0.00% 4 Missing ⚠️
src/astrohack/panel.py 40.00% 3 Missing ⚠️
src/astrohack/antenna/telescope.py 60.00% 2 Missing ⚠️
src/astrohack/dio.py 77.77% 2 Missing ⚠️
src/astrohack/utils/file.py 87.50% 2 Missing ⚠️
... and 3 more

📢 Thoughts on this report? Let us know!

@vsmagalhaes vsmagalhaes merged commit 90828a2 into astrohack-dev Jul 3, 2025
18 checks passed
@vsmagalhaes vsmagalhaes deleted the 329-add-elevation-and-azimuth-information-on-txt-outputs branch July 3, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vsmagalhaes vsmagalhaes

Labels

Area:SciDev Science Feature development,validation, bugfix enhancement New feature or request visualization Issues regarding visualization

Projects

None yet

Milestone

VLA Support

Development

Successfully merging this pull request may close these issues.

Add Elevation and Azimuth information on txt outputs

1 participant

@vsmagalhaes