-
Notifications
You must be signed in to change notification settings - Fork 101
feat: production setup #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
# Conflicts: # app/components/AppHeader.vue
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
This PR includes:
en.jsonfile)header-logoto logo at index page (now the search and the npmx will transition, check https://streamable.com/0e3u5c)public-devandpublic-stagingfolder with the favicon-svg variants: generated all the pwa icons with a new script at package.jsonshared/typesto defineBuildInfo(exported)BuildInfoatappConfigNuxtPWAAssetstoapp.vueto inject favicons,theme_colorand apple touch iconsimple-gitas dependency and@types/nodeandvite-plugin-pwaas dev dependency (vite-plugin-pwaadded to fixtest:types, usingNuxtPWAAssetscomponent atapp.vue)..gitattributesto includetext=auto, png pwa icons were corruptedRESOLVED using
nuxt.option.devthx to Daniel:It is weird,sdt-envnot resolvingisDevelopmentwhen runningnr dev(favicon and logo using public-staging and should use public-dev).The preview here using
publicinsteadpublic-stagingicon: we will need to add some environment-variables at Vercel por Preview deployment and review the ones being used atconfig/env.tsmodule.RESOLVED via
.gitattributes(thx to @shuuji3 🥳 ):GH cannot display generated pwa icons (png) here in files tab, on my local it is fine:PWA Icons on my local
public pwa icons

public-dev pwa icons

public-staging pwa icons

I need to instead of the version, we show canary · fe62b79 with a link to the commit:
canary · fe62b79with a link to the commitresolves #301