Skip to content

Conversation

@userquin
Copy link
Contributor

@userquin userquin commented Jan 30, 2026

This PR includes:

  • add version to package.json (0.0.0, no idea why is not there)
  • new translation keys for alt. logo, version and build (only at en.json file)
  • add header-logo to logo at index page (now the search and the npmx will transition, check https://streamable.com/0e3u5c)
  • add build info (module augmentation at nuxt.config.ts) with similar approach used at elk.zone without the storage (we don't have mocked servers here)
  • add public-dev and public-staging folder with the favicon-svg variants: generated all the pwa icons with a new script at package.json
  • included a new env module to shared/types to define BuildInfo (exported)
  • added build-env module to override public folder and expose BuildInfo at appConfig
  • add NuxtPWAAssets to app.vue to inject favicons, theme_color and apple touch icon
  • added simple-git as dependency and @types/node and vite-plugin-pwa as dev dependency (vite-plugin-pwa added to fix test:types, using NuxtPWAAssets component at app.vue).
  • updates .gitattributes to include text=auto, png pwa icons were corrupted

RESOLVED using nuxt.option.dev thx to Daniel: It is weird, sdt-env not resolving isDevelopment when running nr dev (favicon and logo using public-staging and should use public-dev).

The preview here using public instead public-staging icon: we will need to add some environment-variables at Vercel por Preview deployment and review the ones being used at config/env.ts module.

RESOLVED via .gitattributes (thx to @shuuji3 🥳 ): GH cannot display generated pwa icons (png) here in files tab, on my local it is fine:

PWA Icons on my local

public pwa icons
public pwa icons

public-dev pwa icons
public-dev icons

public-staging pwa icons
public-staging icons

I need to instead of the version, we show canary · fe62b79 with a link to the commit:

  • add version and link with the commit (short) somewhere (I think adding it below the AppHeader logo will be fine, also at home page) => clear way to tell from the UI that this is the main staging version, see different color for logo at the top right in main.elk.zone.
  • instead of the version, we show canary · fe62b79 with a link to the commit
  • command to release automatically bumping versions (patches, minor, major), GH releases, etc.

resolves #301

@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 30, 2026 6:19am
npmx.dev Ready Ready Preview, Comment Jan 30, 2026 6:19am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Jan 30, 2026 6:19am

Request Review

# Conflicts:
#	app/components/AppHeader.vue
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Staging and versioned production setup

1 participant