Skip to content

feat: package diffing #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
taskylizard wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: package diffing #356

taskylizard wants to merge 8 commits into from
+2,723 −1

Conversation

@taskylizard
Copy link
Contributor

@taskylizard taskylizard commented Jan 29, 2026 •
edited
Loading

This should be good to go now, though the network calls may be a bit iffy, let me know any suggestions.

@vercel
Copy link

vercel bot commented Jan 29, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 30, 2026 10:19pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jan 30, 2026 10:19pm
npmx-lunaria Ignored Ignored Jan 30, 2026 10:19pm

Request Review

@github-actions
Copy link

github-actions bot commented Jan 29, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@taskylizard taskylizard force-pushed the feat/versions-diff-view branch from 28c17c5 to a787b16 Compare January 29, 2026 21:33
@taskylizard taskylizard force-pushed the feat/versions-diff-view branch from a787b16 to 3149f5d Compare January 29, 2026 21:36
@taskylizard
WIP
376868d 
WIP

fix: detect file modifications using hashes

fix: surface diff fetch failures

fix: handle file-directory transitions in compare

WIP
@taskylizard taskylizard force-pushed the feat/versions-diff-view branch from 3149f5d to 376868d Compare January 29, 2026 21:39
@taskylizard taskylizard marked this pull request as ready for review January 30, 2026 08:17
danielroe
danielroe reviewed Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make some tweaks later - but this looks amazing!

a few notes to myself (or you if you get a chance!):

  • we should have consistent font size for code trees between diff viewer + code viewer
  • we should have a similar kind of mobile panel that slides in between the two of them
  • we should use the toggles from settings.vue rather than checkboxes
  • I think there are some hydration issues but not sure if that originates in this PR
  • the sliders can also be more aligned with the existing visual styles - some nice work from @serhalp in the search filters might be a helpful guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taskylizard @danielroe