Skip to content

feat: arabic i18n #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 11 commits into from
Jan 29, 2026
+1,535 −62
Merged

feat: arabic i18n #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0aa4418
feat: add arabic strings
skaldebane Jan 29, 2026
f88777e
fix: add pluralization for `found_packages` for en
skaldebane Jan 29, 2026
b57d9cc
fix: supply plural number in various t calls
skaldebane Jan 29, 2026
62195bc
fix: add lunaria files
skaldebane Jan 29, 2026
6a7b190
fix: config type error
skaldebane Jan 29, 2026
8b3b270
feat: update arabic translations
skaldebane Jan 29, 2026
e576052
fix: add 0 pluralization to found_packages
skaldebane Jan 29, 2026
4679470
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 29, 2026
94e0610
fix: add back @intlify/core-base
skaldebane Jan 29, 2026
53a6afd
Merge branch 'main' into i18n/ar
danielroe Jan 29, 2026
972acb0
chore: add i18n config to knip entrypoint
danielroe Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/components/PackageVersions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,13 @@ function getTagVersions(tag: string): VersionDisplay[] {
<span class="text-xs text-fg-muted py-1.5">
{{ $t('package.versions.other_versions') }}
<span v-if="hiddenTagRows.length > 0" class="text-fg-subtle">
({{ $t('package.versions.more_tagged', { count: hiddenTagRows.length }) }})
({{
$t(
'package.versions.more_tagged',
{ count: hiddenTagRows.length },
hiddenTagRows.length,
)
}})
</span>
</span>
</button>
Expand Down
8 changes: 7 additions & 1 deletion app/pages/search.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,13 @@ defineOgImageComponent('Default', {
role="status"
class="text-fg-muted text-sm mt-4 font-mono"
>
{{ $t('search.found_packages', { count: formatNumber(visibleResults.total) }) }}
{{
$t(
'search.found_packages',
{ count: formatNumber(visibleResults.total) },
visibleResults.total,
)
}}
<span v-if="status === 'pending'" class="text-fg-subtle">{{
$t('search.updating')
}}</span>
Expand Down
115 changes: 57 additions & 58 deletions config/i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,26 @@ interface LocaleObjectData extends LocaleObject {
}

export const countryLocaleVariants: Record<string, (LocaleObjectData & { country?: boolean })[]> = {
/*ar: [
// ar.json contains ar-EG translations
// { code: 'ar-DZ', name: 'Arabic (Algeria)' },
// { code: 'ar-BH', name: 'Arabic (Bahrain)' },
{ country: true, code: 'ar-EG', name: 'العربية' },
// { code: 'ar-EG', name: 'Arabic (Egypt)' },
// { code: 'ar-IQ', name: 'Arabic (Iraq)' },
// { code: 'ar-JO', name: 'Arabic (Jordan)' },
// { code: 'ar-KW', name: 'Arabic (Kuwait)' },
// { code: 'ar-LB', name: 'Arabic (Lebanon)' },
// { code: 'ar-LY', name: 'Arabic (Libya)' },
// { code: 'ar-MA', name: 'Arabic (Morocco)' },
// { code: 'ar-OM', name: 'Arabic (Oman)' },
// { code: 'ar-QA', name: 'Arabic (Qatar)' },
// { code: 'ar-SA', name: 'Arabic (Saudi Arabia)' },
// { code: 'ar-SY', name: 'Arabic (Syria)' },
// { code: 'ar-TN', name: 'Arabic (Tunisia)' },
// { code: 'ar-AE', name: 'Arabic (U.A.E.)' },
// { code: 'ar-YE', name: 'Arabic (Yemen)' },
],*/
ar: [
// ar.json contains ar-EG translations
// { code: 'ar-DZ', name: 'Arabic (Algeria)' },
// { code: 'ar-BH', name: 'Arabic (Bahrain)' },
{ country: true, code: 'ar-EG', name: 'العربية' },
// { code: 'ar-EG', name: 'Arabic (Egypt)' },
// { code: 'ar-IQ', name: 'Arabic (Iraq)' },
// { code: 'ar-JO', name: 'Arabic (Jordan)' },
// { code: 'ar-KW', name: 'Arabic (Kuwait)' },
// { code: 'ar-LB', name: 'Arabic (Lebanon)' },
// { code: 'ar-LY', name: 'Arabic (Libya)' },
// { code: 'ar-MA', name: 'Arabic (Morocco)' },
// { code: 'ar-OM', name: 'Arabic (Oman)' },
// { code: 'ar-QA', name: 'Arabic (Qatar)' },
// { code: 'ar-SA', name: 'Arabic (Saudi Arabia)' },
// { code: 'ar-SY', name: 'Arabic (Syria)' },
// { code: 'ar-TN', name: 'Arabic (Tunisia)' },
// { code: 'ar-AE', name: 'Arabic (U.A.E.)' },
// { code: 'ar-YE', name: 'Arabic (Yemen)' },
],
en: [
// en.json contains en-US translations
{ country: true, code: 'en-US', name: 'English (US)' },
Expand Down Expand Up @@ -84,47 +84,46 @@ const locales: (Omit<LocaleObjectData, 'code'> & { code: string })[] = [
file: 'en.json',
name: 'English',
},
{
code: 'ar-EG',
Copy link
Contributor

@userquin userquin Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be ar not ar-EG, buildLocales will add ar-EG using both files

Copy link
Contributor Author

@skaldebane skaldebane Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, that's what it was from the elk code, but it causes a type error 🤔

Copy link
Contributor

@userquin userquin Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to run pnpm nuxt prepare or start dev server, locales are typed at i18n

Copy link
Contributor Author

@skaldebane skaldebane Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still seems to give a type error. happens on CI too

Copy link
Contributor

@userquin userquin Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking on my local, I changed the type

Copy link
Contributor Author

@skaldebane skaldebane Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot, commented in the same moment
yes vscode. before the error was on the string itself, now (idk what changed) it seems to be @intlify/core-base

and in a previous commit it failed in CI here too (on the type of the strring itself)

Copy link
Contributor

@userquin userquin Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arrggg missing @intlify/core-base, can you run pnpm add @intlify/core-base and commit and push package.json and pnpm-lock.yaml

Copy link
Contributor Author

@skaldebane skaldebane Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when'd that disappear! i just added it back, here's the error:

Type '"ar"' is not assignable to type '"ar-EG" | "de-DE" | "en-US" | "es-419" | "es-ES" | "fr-FR" | "it-IT" | "ja-JP" | "zh-CN"'.ts(2322)
module.d.mts(447, 5): The expected type comes from property 'code' which is declared here on type 'LocaleObjectData'

(property) LocaleObject<"ar-EG" | "de-DE" | "en-US" | "es-419" | "es-ES" | "fr-FR" | "it-IT" | "ja-JP" | "zh-CN">.code: "ar-" | "de-DE" | "en-US" | "es-419" | "es-ES" | "fr-FR" | "it-IT" | "ja-JP" | "zh-CN"

Copy link
Contributor Author

@skaldebane skaldebane Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently it was removed in 4ca6ce8, knip is now failing CI

Copy link
Collaborator

@danielroe danielroe Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed ✅

file: 'ar.json',
name: 'العربية',
dir: 'rtl',
pluralRule: (choice: number) => {
const name = new Intl.PluralRules('ar-EG').select(choice)
return { zero: 0, one: 1, two: 2, few: 3, many: 4, other: 5 }[name]
},
} satisfies LocaleObjectData,
/*{
code: 'ar',
file: 'ar.json',
name: 'العربية',
dir: 'rtl',
pluralRule: (choice: number) => {
const name = new Intl.PluralRules('ar-EG').select(choice)
return { zero: 0, one: 1, two: 2, few: 3, many: 4, other: 5 }[name]
},
} satisfies LocaleObjectData,
{
code: 'ckb',
file: 'ckb.json',
name: 'کوردیی ناوەندی',
dir: 'rtl',
pluralRule: (choice: number) => {
const name = new Intl.PluralRules('ckb').select(choice)
return { zero: 0, one: 1, two: 2, few: 3, many: 4, other: 5 }[name]
},
} satisfies LocaleObjectData,
{
code: 'fa-IR',
file: 'fa-IR.json',
name: 'فارسی',
dir: 'rtl',
pluralRule: (choice: number) => {
const name = new Intl.PluralRules('fa-IR').select(choice)
return { zero: 0, one: 1, two: 2, few: 3, many: 4, other: 5 }[name]
},
} satisfies LocaleObjectData,
{
code: 'ca',
file: 'ca.json',
name: 'Català',
code: 'ckb',
file: 'ckb.json',
name: 'کوردیی ناوەندی',
dir: 'rtl',
pluralRule: (choice: number) => {
const name = new Intl.PluralRules('ckb').select(choice)
return { zero: 0, one: 1, two: 2, few: 3, many: 4, other: 5 }[name]
},
{
code: 'el-GR',
file: 'el-GR.json',
name: 'Ελληνικά',
} satisfies LocaleObjectData,
{
code: 'fa-IR',
file: 'fa-IR.json',
name: 'فارسی',
dir: 'rtl',
pluralRule: (choice: number) => {
const name = new Intl.PluralRules('fa-IR').select(choice)
return { zero: 0, one: 1, two: 2, few: 3, many: 4, other: 5 }[name]
},
*/
} satisfies LocaleObjectData,
{
code: 'ca',
file: 'ca.json',
name: 'Català',
},
{
code: 'el-GR',
file: 'el-GR.json',
name: 'Ελληνικά',
},*/
{
code: 'de-DE',
file: 'de-DE.json',
Expand Down
1 change: 1 addition & 0 deletions i18n/locales/ar-EG.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
Loading