Extract terminfo path #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOAD-TERMINFO was iterating over all the possible locations for a given terminfo database, attempting to open the file, if the file was opened successfully then parse the terminfo database and return. Instead have the extract the searching for the locating of the term info database to a separate function so that load-terminfo only takes care of parsing the database.
The variable is only being used for one implementation, CMUCL.
Owner
|
Hi @PuercoPop, I am sorry for taking so long to getting back to you with a comment. I haven't had my linux box operational in about a year, I've been busy, and I wanted to test the code update before accepting it. I think the change is fine on inspection. I agree that moving the defcaps to their own file could make sense. I don't think that was done initially because this library was originally designed to be passed around as a single file. If I were to redo it, I'd also put package info in its own file. At this point, I'd just as soon leave the code where it is so that changes (if any) are more easily tracked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btw, what do you think about moving the DEFCAPs to their own file?