Skip to content

Conversation

@nemethf
Copy link
Contributor

@nemethf nemethf commented Nov 28, 2013

This is the second version of #102


As a followup to our discussion on pox-dev (http://lists.noxrepo.org/pipermail/pox-dev-noxrepo.org/2013-November/001188.html) I'd like share the current state of my modifications/additions. I wrote some of my doubts in comments. Moreover, I haven't tested the new dns_spy module at all.

Please, review.

Thank you.

@nemethf nemethf mentioned this pull request Nov 28, 2013
Copy link

@oozzie67-ux oozzie67-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hardline to a shortcut reversal is on my opinion a perfect fit to the adjustment in line 255. The add on through c++ and Javascript is superb! Keep up the good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants