handle optional parentheses in chrome's regex#46
Open
mattzucker wants to merge 1 commit intonovocaine:masterfrom
Open
handle optional parentheses in chrome's regex#46mattzucker wants to merge 1 commit intonovocaine:masterfrom
mattzucker wants to merge 1 commit intonovocaine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the bug identified here #45
The regex for chrome works whether the line in the stack trace has parentheses around the file URL or not. Instead of relying on the parentheses, the regex now expects there to be a space in between " at " and the file URL. This should be a more robust approach to match the stack trace.
Examples used for testing
is mapped to
Previous mapping continues to work, such as
is mapped to