Open
Conversation
As reported in fish-shell/fish-shell#11609 (comment), a Proxmox Terminal (https://git.proxmox.com/git/novnc-pve) fails to parse OSC commands such as: bash$ printf '\x1b]133;A;click_events=1\x07' Judging by the Git history of the novnc-pve repo, it looks like they use websockify-js. They no longer vendor VT100.js, so hopefully we only need to fix this here. Untested (happy to do that; not yet sure how).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in
fish-shell/fish-shell#11609 (comment),
a Proxmox Terminal (https://git.proxmox.com/git/novnc-pve) fails to
parse OSC commands such as:
The terminal should output nothing.
Judging by the Git history of the novnc-pve repo, it looks like they
use websockify-js. They no longer vendor VT100.js, so hopefully
we only need to fix this here. Untested (happy to do that; not yet
sure how).