Fix quantization param overrides in task grid#7
Open
Sbboss wants to merge 2 commits intonovitalabs:mainfrom
Open
Fix quantization param overrides in task grid#7Sbboss wants to merge 2 commits intonovitalabs:mainfrom
Sbboss wants to merge 2 commits intonovitalabs:mainfrom
Conversation
Collaborator
Code ReviewThe core fix looks correct and tests are valuable. A few suggestions before merging: 1. Precedence Rule ClarificationWhen both
2. Test Robustness
3. Code Style
4. PR Template IssueThe Review assisted by GPT-5.2 |
Author
|
Thanks for the review. I have made the pertinent changes, please check once. |
Author
|
Hey @k-l-lambda , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
parametersinto__quant__*for grid expansion.Testing
python tests/test_quant_param_override.pyChecklist
Notes