feat: Add Note about implement external trait to external type, wrapper pattern, add example#91
Open
afifurrohman-id wants to merge 3 commits intonovalagung:masterfrom
Open
feat: Add Note about implement external trait to external type, wrapper pattern, add example#91afifurrohman-id wants to merge 3 commits intonovalagung:masterfrom
afifurrohman-id wants to merge 3 commits intonovalagung:masterfrom
Conversation
…` instead of `camelCase`
…xternal type, wrapper pattern, add example
Owner
|
I'll circle back to this PR with intensive review. at a glance there are a bunch of new phrases or keywords that need to be explained clearly, e.g. what is internal-external trait, what is local type. these keywords are not used in this ebook, adding them without a clear explanation potentially generates more confusion for the reader. it is better to carefully keep in mind the narration because our target audience is beginner. I appreciate the PR. Will have it reviewed and merged soon once I have the time. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.