WIP: Remove routing_tree dependency and remake how we are handling routes#350
Open
WIP: Remove routing_tree dependency and remake how we are handling routes#350
Conversation
…y server already runs on the configuration given
- Rename module/file from nova_routing_trie to nova_routing_tree
- Add find/4 with router-compatible API (Host, Path, Method, Tree)
returning {ok, Bindings, Payload} | {error, not_found} |
{error, comparator_not_found, AllowedMethods}
- Handle '_' as wildcard method (maps to <<"ALL">>)
- Handle integer paths (status codes like 404)
- Fix insert/5 wrapper in nova_router to unwrap {ok, Tree} return
- Fix remove_application/1 to use StorageBackend instead of
hardcoded persistent_term
- Fix foldl route tuple pattern to include Method (4-tuple)
- Remove dead Pathinfo pattern match clause
- Add eunit tests for find/4, integer paths, wildcard method
- All types renamed: trie -> tree, trie_node -> tree_node
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # src/nova_router.erl
Taure
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the Nova application's ability to manage multiple sub-applications dynamically, refactors routing logic to use a new trie-based backend, and adds new API functions for programmatic control. The changes enhance modularity, allow for pragmatic application lifecycle management, and transition routing from the old
routing_treetonova_routing_triefor better performance and maintainability.