fix: correct remaining source-accuracy issues#6
Merged
Conversation
- JSON controllers in changesets.md, advanced-data.md, pubsub.md use `json` key (not `params`) for decoded JSON bodies - Auth tests in testing.md set `params` directly on the request map instead of using `with_json` (which sets the `json` key, not `params`) - validate_format regex patterns use binary syntax per Kura spec Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round 2 of cross-referencing all chapters against Nova/Kura source code. Covers the 14 chapters not reviewed in PR #5.
params→jsonfor decoded JSON bodies (same class of bug as PR fix: correct code examples against Nova/Kura source #5)nova_test_req:with_json/2sets thejsonkey, butusername_password/1matches onparams(URL-encoded form data). Fixed to setparamsdirectly on the request map.validate_formatregex: string → binary per Kura spec (changesets.md + cheat-sheet.md)Chapters reviewed with no issues found
introduction.md, create-app.md, routing.md, plugins.md, setup.md, associations.md, transactions-bulk.md, deployment.md, openapi-tools.md, opentelemetry.md
Test plan
🤖 Generated with Claude Code