fix: correct bugs and gaps in database setup chapter#10
Merged
Conversation
…F, and simplified login flow
- Add ErlyDTL syntax reference table, base layout with template inheritance
- Add CSRF token to login form (required by nova_csrf_plugin)
- Document all template options (view, headers, status_code)
- Move credential validation from security function into controller
- Simplify session_auth to return {redirect, "/login"} instead of bare false
- Remove manual session ID generation — use Nova's auto-created sessions
- Consolidate routes from three groups to two (public + protected)
- Add use_sessions config, session API return types, and delete/1 cookie behavior
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cross-referenced against Kura and rebar3_kura source to fix:
- config/0 now matches generator output (application:get_env for database,
<<"postgres">> password, ?MODULE pool)
- Clarify kura_repo behaviour only requires config/0 callback
- Rewrite "Configuring the repo" to explain env-specific overrides
- Add kura_migrator:migrate/1 call in supervisor startup
- Fix provider hook from {post,...} to {pre,...}
- Fix query example to show actual return format ({ok, [#{...}]})
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/0to match actualrebar3_kuraoutput (application:get_envfor database,<<"postgres">>password,?MODULEpool)kura_repobehaviour only requiresconfig/0as a callbacksys.configkura_migrator:migrate/1call in supervisor startup with admonish tip about production usage{post,...}to{pre,...}to matchrebar3_kura_setup.erlquery/2example to show actual return format ({ok, [#{...}]}not raw pgo result)Test plan
mdbook buildsucceeds without errors🤖 Generated with Claude Code