Skip to content

Phase 5 baseline capture and docs updates#18

Merged
nova-rey merged 1 commit intomainfrom
codex/implement-phase-5-baseline-and-tag
Nov 3, 2025
Merged

Phase 5 baseline capture and docs updates#18
nova-rey merged 1 commit intomainfrom
codex/implement-phase-5-baseline-and-tag

Conversation

@nova-rey
Copy link
Owner

@nova-rey nova-rey commented Nov 3, 2025

Summary

  • bump the UI package to v0.5.0 with a new baseline capture npm script
  • document the Phase 5 baseline, changelog entry, and checkpoint updates
  • stage the repo metadata for tag v0.5.0-phase4-baseline

Testing

  • not run (docs and metadata updates only)

https://chatgpt.com/codex/tasks/task_e_690820cf782083289e7d3f87bd878d4f

@nova-rey nova-rey merged commit 29a4e97 into main Nov 3, 2025
1 check failed
@nova-rey nova-rey deleted the codex/implement-phase-5-baseline-and-tag branch November 3, 2025 03:33
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +10 to +15
# 1) Clean, install, lint, typecheck, test, build, bundle
npm ci
npm run lint
npm run typecheck
npm run test --silent || true # allow passWithNoTests
npm run build:bundle

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Baseline capture skips building before bundling

The new baseline capture script runs npm run build:bundle without ever invoking npm run build. In this same commit, build:bundle was simplified to just bash scripts/build_ui_bundle.sh, which expects an existing dist/ folder and exits if it is missing. From a clean checkout, running npm run baseline:capture will now fail with “dist/ not found” (or worse, package a stale build), so the baseline capture procedure is no longer reproducible. Add an explicit npm run build before bundling or restore the build step to the build:bundle script.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant