Skip to content

Phase 4 baseline: replay viewer and run detail polish#17

Merged
nova-rey merged 1 commit intomainfrom
codex/add-replay-viewer-and-metadata-polish
Nov 3, 2025
Merged

Phase 4 baseline: replay viewer and run detail polish#17
nova-rey merged 1 commit intomainfrom
codex/add-replay-viewer-and-metadata-polish

Conversation

@nova-rey
Copy link
Owner

@nova-rey nova-rey commented Nov 3, 2025

Summary

  • add /replay/:id with lazy bankroll chart, playback controls, and table backed by the new replay payload types
  • extend Run Detail with runtime/peak/drawdown metadata, manifest preview support, and a replay shortcut
  • refresh docs, mocks, and configuration for the phase 4 baseline and chart dependencies

Testing

  • npm run typecheck
  • npm run lint
  • npm run test
  • npm run build
  • VITE_CSC_USE_MOCK=true npm run dev

https://chatgpt.com/codex/tasks/task_e_6907f9c56994832897bc1db90fb2c989

…h metadata & manifest preview, docs to v0.5.0-phase4-baseline
@nova-rey nova-rey merged commit e39da74 into main Nov 3, 2025
1 check passed
@nova-rey nova-rey deleted the codex/add-replay-viewer-and-metadata-polish branch November 3, 2025 01:00
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 16 to +19
<Route path="/builder" element={<Builder />} />
<Route path="/runs" element={<RunsList />} />
<Route path="/runs/:id" element={<RunDetail />} />
<Route path="/replay" element={<Replay />} />
<Route path="/replay/:id" element={<Replay />} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update navigation link to match new /replay/:id route

The router now only defines a replay page at path="/replay/:id" (this diff). However the top navigation still links to /replay (see NavBar.tsx), so clicking "Replay" routes to a path that no longer exists and renders nothing. Users can’t reach the new replay viewer from the navbar unless they manually type an ID or navigate from elsewhere. Consider changing the nav link to include an ID (or adding a fallback route) so the menu does not send users to a dead route.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant