Phase 4 baseline: replay viewer and run detail polish#17
Conversation
…h metadata & manifest preview, docs to v0.5.0-phase4-baseline
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Route path="/builder" element={<Builder />} /> | ||
| <Route path="/runs" element={<RunsList />} /> | ||
| <Route path="/runs/:id" element={<RunDetail />} /> | ||
| <Route path="/replay" element={<Replay />} /> | ||
| <Route path="/replay/:id" element={<Replay />} /> |
There was a problem hiding this comment.
Update navigation link to match new
/replay/:id route
The router now only defines a replay page at path="/replay/:id" (this diff). However the top navigation still links to /replay (see NavBar.tsx), so clicking "Replay" routes to a path that no longer exists and renders nothing. Users can’t reach the new replay viewer from the navbar unless they manually type an ID or navigate from elsewhere. Consider changing the nav link to include an ID (or adding a fallback route) so the menu does not send users to a dead route.
Useful? React with 👍 / 👎.
Summary
/replay/:idwith lazy bankroll chart, playback controls, and table backed by the new replay payload typesTesting
https://chatgpt.com/codex/tasks/task_e_6907f9c56994832897bc1db90fb2c989