Conversation
…uilder smoke test
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export default defineConfig({ | ||
| plugins: [react()], | ||
| base: "./", | ||
| build: { outDir: "dist", emptyOutDir: true }, | ||
| test: { | ||
| environment: "jsdom", | ||
| setupFiles: ["src/test/setup.ts"], | ||
| globals: true, | ||
| css: true, | ||
| }, |
There was a problem hiding this comment.
Preserve base path in Vite config
The new vite.config.ts only adds Vitest configuration and drops the previous base: "./" (and related build options). Vite now defaults base to /, so the emitted bundle uses absolute asset URLs. The packaging workflow (scripts/build_ui_bundle.sh → ui_static.tar.gz described in the docs) depends on relative URLs so the static bundle can be served from an arbitrary sub-path or even opened directly from disk. After this change those deployments will 404 on all JS/CSS assets unless the bundle is hosted at the domain root. Consider keeping the original base/build options alongside the new test settings.
Useful? React with 👍 / 👎.
Summary
eslint.config.jsthat wires in TypeScript, React, and React Hooks rules while deferring formatting to PrettierTesting
https://chatgpt.com/codex/tasks/task_e_6907c3babc8c8328bdb7ebd64bec5abf