Skip to content

chore: adopt ESLint flat config and add Builder smoke test#11

Merged
nova-rey merged 1 commit intomainfrom
codex/migrate-to-eslint-flat-config-and-prettier
Nov 2, 2025
Merged

chore: adopt ESLint flat config and add Builder smoke test#11
nova-rey merged 1 commit intomainfrom
codex/migrate-to-eslint-flat-config-and-prettier

Conversation

@nova-rey
Copy link
Owner

@nova-rey nova-rey commented Nov 2, 2025

Summary

  • replace the legacy ESLint configuration with a flat eslint.config.js that wires in TypeScript, React, and React Hooks rules while deferring formatting to Prettier
  • add repository-wide Prettier configuration, scripts, and ignore file, reformatting existing sources to match the new style
  • wire Vitest into Vite with a jsdom environment, add shared testing setup, and create a Builder render smoke test
  • document the new checkpoint status across project docs and metadata files

Testing

  • npm run format:check
  • npm run lint
  • npm run typecheck
  • npm run test

https://chatgpt.com/codex/tasks/task_e_6907c3babc8c8328bdb7ebd64bec5abf

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 4 to +11
export default defineConfig({
plugins: [react()],
base: "./",
build: { outDir: "dist", emptyOutDir: true },
test: {
environment: "jsdom",
setupFiles: ["src/test/setup.ts"],
globals: true,
css: true,
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve base path in Vite config

The new vite.config.ts only adds Vitest configuration and drops the previous base: "./" (and related build options). Vite now defaults base to /, so the emitted bundle uses absolute asset URLs. The packaging workflow (scripts/build_ui_bundle.shui_static.tar.gz described in the docs) depends on relative URLs so the static bundle can be served from an arbitrary sub-path or even opened directly from disk. After this change those deployments will 404 on all JS/CSS assets unless the bundle is hosted at the domain root. Consider keeping the original base/build options alongside the new test settings.

Useful? React with 👍 / 👎.

@nova-rey nova-rey merged commit 2d59bd8 into main Nov 2, 2025
1 check passed
@nova-rey nova-rey deleted the codex/migrate-to-eslint-flat-config-and-prettier branch November 2, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant