Conversation
…log (Session Lifecycle & Capabilities)
…dmap-and-changelog
…workflow; add minimal ruff/mypy config and report hygiene
…gauntlet-workflows
…t mypy) + stable tool config and report hygiene
…flow-and-tools
…add diagnostic workflow
…t-workflow-and-diagnostics
…re-diagnostics
…py, build, import smoke, examples smoke)
…artifacts, PYTHONPATH seed)
…nerate-reports
…to-crapssim-api
…-and-tests-layout
…i-packaging-and-docs
Added new files and directories to .gitignore to exclude them from version control.
…rtifacts-cleanup
Add configuration for CrapsSim project including metadata and dependencies.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _construct_bet( | ||
| bet_type: type[Bet], | ||
| *, | ||
| number: Optional[int], | ||
| amount: float, | ||
| ) -> Bet: | ||
| try: | ||
| if number is None: | ||
| return bet_type(amount) | ||
| return bet_type(number, amount) |
There was a problem hiding this comment.
set_bet_amount rebuilds the bet via _construct_bet, but _construct_bet only passes the number and amount (return bet_type(number, amount)). For Odds bets this drops the existing always_working flag, so a bettor who previously called set_odds_working will silently revert to non-working odds whenever they reduce the amount. After an odds bet is marked as working, calling the reduce API on it will reset it to the default come-out behaviour and the player cannot detect that this happened. _construct_bet needs to copy additional attributes from the removed bet when re-creating it.
Useful? React with 👍 / 👎.
Updated CHANGELOG to reflect changes in version 0.4.0, including new bets, strategies, and fixes.
1 participant
No description provided.