Skip to content

Phase 10 HTTP engine docs, harness, and baseline#162

Merged
nova-rey merged 1 commit intomainfrom
codex/implement-phase-10-engine-api-integration
Nov 15, 2025
Merged

Phase 10 HTTP engine docs, harness, and baseline#162
nova-rey merged 1 commit intomainfrom
codex/implement-phase-10-engine-api-integration

Conversation

@nova-rey
Copy link
Owner

Summary

  • expand ENGINE_API_ADAPTER.md and phase checklist/bible entries to document HTTP engine usage and wrap up Phase 10 checkpoints
  • add a deterministic parity harness module with a FastAPI-based test that skips when CrapsSim-API dependencies are absent
  • capture seeded HTTP engine baseline artifacts and refresh snapshot/entrypoint metadata

Testing

  • pytest
  • ruff check
  • black crapssim_control/testing/engine_parity.py tests/test_engine_parity_harness.py

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +10 to +13
from crapssim_control.engine.http_api_adapter import HttpEngineAdapter
from crapssim_control.testing.engine_parity import run_parity_test
from crapssim_control.engine.factory import build_inprocess_engine_adapter
from crapssim_control.config import RunConfig

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Import helper that does not exist

The parity harness test imports build_inprocess_engine_adapter, but crapssim_control.engine.factory exposes only build_engine_adapter; no such function exists anywhere in the repo. In environments where crapssim_api.http and fastapi are installed (so the module is not skipped), the import fails before the test body executes, leaving the new test suite permanently broken. Please import the correct builder or implement the missing helper so the test can actually run.

Useful? React with 👍 / 👎.

@nova-rey nova-rey merged commit f529f1a into main Nov 15, 2025
4 checks passed
@nova-rey nova-rey deleted the codex/implement-phase-10-engine-api-integration branch November 15, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant