Phase 10 HTTP engine docs, harness, and baseline#162
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from crapssim_control.engine.http_api_adapter import HttpEngineAdapter | ||
| from crapssim_control.testing.engine_parity import run_parity_test | ||
| from crapssim_control.engine.factory import build_inprocess_engine_adapter | ||
| from crapssim_control.config import RunConfig |
There was a problem hiding this comment.
Import helper that does not exist
The parity harness test imports build_inprocess_engine_adapter, but crapssim_control.engine.factory exposes only build_engine_adapter; no such function exists anywhere in the repo. In environments where crapssim_api.http and fastapi are installed (so the module is not skipped), the import fails before the test body executes, leaving the new test suite permanently broken. Please import the correct builder or implement the missing helper so the test can actually run.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task