Bug Fix: Entity ID Mismatch in Status Retrieval, unused params #151
+38
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug related to inconsistent parameter usage when retrieving status by slug for single types in a Strapi integration. It aligns backend parameter names with what is sent from the frontend and removes unnecessary logic.
Changes
Renamed parameter from entityDocumentId to entityId in
controllers.ts(getStatusBySlug()) androutes.ts(/get-status/:entityId) to match the frontend input.Removed unused entityDocumentId when closing an entity — we now delete all items by entityId.
Removed unused entityId in
getStatusByIdAndSlug()— lookup is handled via entityDocumentId and user.Notes
No breaking changes or migrations.
No related issues — this was identified while integrating the package into a project.
Testing: Install the package into a Strapi project. The modal should now behave correctly and now pop up when two accounts access the same single type or collection type.