Remove async attribute from script tag #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There is a couple files I accidentally missed, namely asset_list.html & cable_list.html which should probably also be updated too if this fix works |
Contributor
|
Make a PR, it can sit for a bit, those are definitely touched less often, and if we've resolved it for the RAs it's an easy merge. Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix the bug on Firefox (and intermittently on Chrome) where the Power MIC select isn't initialised.
I imagine this has become a problem recently because the new server is returning assets faster/slower/differently than Heroku did, and thus the select.js file is being run too late. Removing the
asyncattribute should mean that the script is loaded consistently.