Skip to content

fix: remove redundant mipmap filesize limits #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KibbeWater wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove redundant mipmap filesize limits #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion RePKG.Application/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ internal static class Constants
public const int MaximumFrameCount = 100_000;
public const int MaximumImageCount = 100;
public const int MaximumMipmapCount = 32;
public const int MaximumMipmapByteCount = 250_000_000; // 250 MB
}
}
4 changes: 0 additions & 4 deletions RePKG.Application/Texture/TexImageReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,6 @@ private byte[] ReadBytes(BinaryReader reader)
if (reader.BaseStream.Position + byteCount > reader.BaseStream.Length)
throw new UnsafeTexException("Detected invalid mipmap byte count - exceeds stream length");

if (byteCount > Constants.MaximumMipmapByteCount)
throw new UnsafeTexException(
$"Mipmap byte count exceeds maximum size: {byteCount}/{Constants.MaximumMipmapByteCount}");

if (!ReadMipmapBytes)
{
reader.BaseStream.Seek(byteCount, SeekOrigin.Current);
Expand Down