Skip to content
This repository was archived by the owner on Jan 25, 2025. It is now read-only.

Conversation

@AlekseyLobanov
Copy link

Hello.

I propose multiple changes that should, as I believe, improve code style with using more idiomatic approaches. This also significantly improves performance for FEN generation. I believe that this method is really important because it's the only standard positions representation.

Before: (benchmark was added, but code is the same)

BenchmarkBoardTextSerialization-16        179582              6439 ns/op

After

BenchmarkBoardTextSerialization-16        593695              1892 ns/op

About 3.4x boost.

@AlekseyLobanov
Copy link
Author

Hello, @notnil. Any thoughts on this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant