Merged
Conversation
mark-dce
force-pushed
the
update_thor_version
branch
from
6bd24d6 to
20f90bd
Compare
**ISSUE**
StackCar installs with a very old version of Thor that call deprecated
DidYouMean methods. These calls raise deprecation warnings under Ruby
versions >= 3.3 and < 3.4. The method is removed in versions of
DidYouMean that run under Ruby >= 3.4.0, causing StackCar failures.
**RESOLUTION**
Update the thor dependency version.
**DETAILS**
Dependencies currently installed by StackCar
```
gem install stack_car
Fetching dotenv-3.1.8.gem
Fetching archive-zip-0.13.1.gem
Fetching thor-0.20.3.gem
Fetching io-like-0.4.0.gem
Fetching stack_car-0.22.0.gem
Successfully installed thor-0.20.3
Successfully installed dotenv-3.1.8
Successfully installed io-like-0.4.0
Successfully installed archive-zip-0.13.1
Successfully installed stack_car-0.22.0
5 gems installed
```
Deprecation warning under Ruby 3.3.9
```
% sc help exec
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Usage:
sc exec ARGS
Options:
-s, [--service=SERVICE]
# Default: web
wraps docker compose exec web unless --service is used to specify
```
Failure under Ruby 3.4.5
```
% sc help exec
/Users/mark/.rbenv/versions/3.4.5/lib/ruby/gems/3.4.0/gems/thor-0.20.3/lib/thor/error.rb:109:in '<class:Thor>': uninitialized constant DidYouMean::SPELL_CHECKERS (NameError)
DidYouMean::SPELL_CHECKERS.merge!(
^^^^^^^^^^^^^^^^
Did you mean? DidYouMean::SpellChecker
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/gems/3.4.0/gems/thor-0.20.3/lib/thor/error.rb:1:in '<top (required)>'
from <internal:/Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:139:in 'Kernel#require'
from <internal:/Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:139:in 'Kernel#require'
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/gems/3.4.0/gems/thor-0.20.3/lib/thor/base.rb:4:in '<top (required)>'
from <internal:/Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:139:in 'Kernel#require'
from <internal:/Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:139:in 'Kernel#require'
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/gems/3.4.0/gems/thor-0.20.3/lib/thor.rb:2:in '<top (required)>'
from <internal:/Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:139:in 'Kernel#require'
from <internal:/Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:139:in 'Kernel#require'
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/gems/3.4.0/gems/stack_car-0.22.0/lib/stack_car/proxy.rb:1:in '<top (required)>'
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/gems/3.4.0/gems/stack_car-0.22.0/lib/stack_car.rb:3:in 'Kernel#require_relative'
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/gems/3.4.0/gems/stack_car-0.22.0/lib/stack_car.rb:3:in '<top (required)>'
from <internal:/Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:139:in 'Kernel#require'
from <internal:/Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:139:in 'Kernel#require'
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/gems/3.4.0/gems/stack_car-0.22.0/exe/sc:3:in '<top (required)>'
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems.rb:319:in 'Kernel#load'
from /Users/mark/.rbenv/versions/3.4.5/lib/ruby/site_ruby/3.4.0/rubygems.rb:319:in 'Gem.activate_and_load_bin_path'
from /Users/mark/.rbenv/versions/3.4.5/bin/sc:25:in '<main>'
```
mark-dce
force-pushed
the
update_thor_version
branch
from
20f90bd to
c593ca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
StackCar installs with a very old version of Thor that call deprecated DidYouMean methods. These calls raise deprecation warnings under Ruby versions >= 3.3 and < 3.4. The method is removed in versions of DidYouMean that run under Ruby >= 3.4.0, causing StackCar failures.
RESOLUTION
Update the version on the Thor dependency.
DETAILS
Dependencies currently installed by StackCar
Deprecation warning under Ruby 3.3.9
Failure under Ruby 3.4.5