Add joystick hat support and ammend opengl includes to identify arm g…#3
Open
noabody wants to merge 1 commit intonotaz:masterfrom
noabody:master
Open
Add joystick hat support and ammend opengl includes to identify arm g…#3noabody wants to merge 1 commit intonotaz:masterfrom noabody:master
noabody wants to merge 1 commit intonotaz:masterfrom
noabody:master
Conversation
…l.h as a structural change to support Linux x86_64 common platform.
notaz
reviewed
Jul 29, 2018
Owner
notaz
left a comment
notaz
left a comment
There was a problem hiding this comment.
Looks ok to me, just a couple of things that may need adjustment.
| #include <EGL/egl.h> | ||
| #include <GLES/gl.h> | ||
| #if defined(__arm__) | ||
| #include <GLES/gl.h> |
Owner
There was a problem hiding this comment.
ARM doesn't automatically mean GLES, just use HAVE_GLES.
|
|
||
| case SDL_JOYHATMOTION: | ||
| if (event->jhat.which != state->joy_id) | ||
| return -2; |
Owner
There was a problem hiding this comment.
Don't you need a check that event->jhat.hat is < 2, like in the SDL_JOYAXISMOTION case, or are there only 2 hats possible? It fear may overflow axis_keydown[] array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l.h as a structural change to support Linux x86_64 common platform.
This relates to notaz/picodrive#90 which is a pull request against picodrive master to expand the common platform to support opengl for Linux x86_64.