x64 support via <virtual_address> #28
Open
+1,638
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irtualAddress (unconditionally), SDKType_PlainOldData -> SDKType_VirtualAddress
…m_mapAttributeControlledParticleSystems. The former is -4 from actual offset and tree access offsets were +4 to compensate
…dAddressFromAddress
…ng for g_SDKCallGetKeyValuesString
Owner
|
Looks fine to me. I need to allocate some time setting this up with an updated Github workflow for SM 1.13 (so I can issue pre-release builds for it) and fixing up the minor stylistic nits, but I do intend to merge this; thanks for putting in the work. |
Owner
|
I still need to work on the variable naming nits, but I did set up the new workflow and confirm that separate releases (stable and x64 / 1.13) build correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires 1.13.0.7278 or greater. No breaking changes other than the SM version requirement and I didn't find any compatibility issues. For 64-bit servers with plugins that rely on TFEconData, as long as the plugin doesn't directly load address values(ex: LoadFromAddress()), then it should work as is without needing a recompile to include <virtual_address>.
Also included is a testing plugin to test all current natives with a single
sm_test_tf2econdatacommand with at least some form of basic validation.This resolves #26