Open
Conversation
* Fix punctuation * Fix broken link * Add Pillow for test dependency This is for the README's example code, which uses Pillow/PIL to save a TIFF file of the image data from a DM4 file. * Add optional example dependencies * Add more complete example * Change to code block This should enable syntax highlighting. * Fix code block syntax * Remove code block GitHub RST support is broken. --------- Co-authored-by: Christopher Field <chris.field@theiascientific.com>
Co-authored-by: Christopher Field <chris.field@theiascientific.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again! The link to the DM4 documentation was broken. It led to a "Page Not Found" at the domain. I believe I have found the same page at a new URL.
This also prompted me to update the README with a more complete example using the PyPI package.
This adds the
exampleoptional dependencies because the example uses dm4, numpy, and Pillow. It also updates the example code to use a context manager. I was getting the following error using the example code "as is" with Python v3.9 in a virtual environment:When I changed the example code to explicitly use the context manager and the
withclause, the error was resolved.