Skip to content

Comments

Add Chunking#49

Open
QuantumEntangledAndy wants to merge 37 commits intonorman784:masterfrom
QuantumEntangledAndy:Chunking
Open

Add Chunking#49
QuantumEntangledAndy wants to merge 37 commits intonorman784:masterfrom
QuantumEntangledAndy:Chunking

Conversation

@QuantumEntangledAndy
Copy link
Contributor

This PR adds some chunking functionality

  • Chunks
    • Generic traits for chunking
    • Flat chunker (name suggestions are OK)
      • This chunk just splits the data into chunks of specified size
    • LOD chunker
      • This chunker uses an octree to make chunks of succesive of higher LOD details
  • Interpolation (used in the LOD chunker)
    • Generic traits for interpolation
    • Nearest neighbor interpolation
    • Trilinear interpolation
  • Example of LOD chunker added to amethyst
LOD.mp4

QuantumEntangledAndy and others added 30 commits July 3, 2021 10:13
Comment typos

Co-authored-by: Norman Paniagua <normanpaniagua@gmail.com>
@norman784
Copy link
Owner

That's a pretty cool approach, I like the idea.

@QuantumEntangledAndy
Copy link
Contributor Author

It's one of the techniques we discussed in #46 based on that in the Volume GFX blog.

This is just a basic implementation. The full implementation also uses marching squares to join the chunks of different resolutions and get rid of the holes.

@QuantumEntangledAndy
Copy link
Contributor Author

I believe that all tests are now passing and that it is ready for review.

I wasn't aware that the doc examples would be compiled and tested like that. It's rather neat, maybe I can add more documentation.

@norman784
Copy link
Owner

Definitely we should add some documentation, I would suggest to document what you think is harder to understand without some short explanation (and example if is needed) because at this stage it is most likely that things will change and maintain the docs up to date with fast changing code is sometimes difficult.

@QuantumEntangledAndy
Copy link
Contributor Author

Ok then :). I think I have this new code already fairly well documented and once this is merged I'll maybe open another PR with doc on my other code too

@norman784
Copy link
Owner

Cool, let me know when the PR is ready to review.

@QuantumEntangledAndy
Copy link
Contributor Author

This PR? I think its fine to review now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants