Skip to content

CantactDev and LogPlayer small fixes (Extended frame, log replay and non-blocking read) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
baipaiha wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CantactDev and LogPlayer small fixes (Extended frame, log replay and non-blocking read) #9

baipaiha wants to merge 5 commits into from

Conversation

@baipaiha
Copy link

@baipaiha baipaiha commented Mar 5, 2019

LogPlayer:

  • Handle extended_id: Mandatory for Frame.init()
  • add a stop() method: So it can be handled like other devices

CantactDev:

  • Add a frame.timestamp: Needed for Logger usage
  • Allow non-blocking read on pySerial: pySerial allow this and it can be useful in some contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@baipaiha