Add and update options to allow mimicry of 22.04 defaults#63
Open
SpoonOne wants to merge 1 commit intonoris-network:masterfrom
Open
Add and update options to allow mimicry of 22.04 defaults#63SpoonOne wants to merge 1 commit intonoris-network:masterfrom
SpoonOne wants to merge 1 commit intonoris-network:masterfrom
Conversation
|
Thank you for your contribution, can you please also add the required module tests? I currently lack the technical means to do local puppet development due to a reinstallation of the workstation. |
Author
|
I'll give it a go when I have the time. From my brief look it appears there might be missing tests for existing options as it is but I'll just look to add the tests for the ones I added/changed. |
|
I had to merge an upgrade to PDK 3.x in #64. Please fetch those changes first, before you try to add more tests. On my Ubuntu 22.04 LTS, pdk 2.x wasn't able to successfully install module dependencies. After that I had to migrate concat to 4.1.0 to be compatible again (is_string, unknown function). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.