Code style changes to conform to ruby code conventions.#22
Open
mnbbrown wants to merge 2 commits intonordigen:masterfrom
Open
Code style changes to conform to ruby code conventions.#22mnbbrown wants to merge 2 commits intonordigen:masterfrom
mnbbrown wants to merge 2 commits intonordigen:masterfrom
Conversation
This includes: - removing uneccessary return statements - removing usage of static class variables - adding .freeze to class constants - using the faraday authorisation plugin - identation - using attr_accessor instead of getter and setter methods.
mnbbrown
force-pushed
the
refactor-ruby-standards-authorisation
branch
from
e3ca5a4 to
4120d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes:
Also add gc_ruboconfig to conform to GoCardless ruby standards :)