Skip to content

Properly bundle TS types#66

Open
krokosik wants to merge 4 commits intonordigen:masterfrom
krokosik:fix-56-bundle-ts-types
Open

Properly bundle TS types#66
krokosik wants to merge 4 commits intonordigen:masterfrom
krokosik:fix-56-bundle-ts-types

Conversation

@krokosik
Copy link

Related Issue

Closes #56

Proposed Changes

  • Relies on Rollup copy plugin rather than cpy
  • Removes unnecessary dev dependencies (why was craco here? that's half the node_modules doing nothing)
  • Fixes TS build errors due to mismatched types of minimatch

Additional Info

I know that there is #53, but it has been unmerged for a while. Maybe a smaller in scope PR can get merged?

@alexanderwassbjer
Copy link

🚀 Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Types exported wrong

2 participants