Skip to content

Conversation

@maheichyk
Copy link
Contributor

@maheichyk maheichyk commented Aug 20, 2025

Follow up to this discussion: nordeck/matrix-poll#683 (comment)

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
@maheichyk maheichyk requested a review from a team as a code owner August 20, 2025 08:49
@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2025

🦋 Changeset detected

Latest commit: ed1fc32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nordeck/matrix-neoboard-widget Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike this idea:
When I have a local dev env set up, and I start the widget yarn dev, then it will be available at http://localhost:5273/. I can /addwidget http://localhost:5273/ and use it in Element Web. Now I start the widget wit yarn dev:https, and it will be available at https://localhost:5273/. My room that already has the widget set up breaks with a http/https mismatch issue, but finding that issue is obfuscated. I check for using the right port etc, it is all correct.

Since I have to /addwidget https://something:abcd anew anyway when running in https mode, I think keeping the current state is preferable - I don't understand the benefit of using the same port for both.

@maheichyk
Copy link
Contributor Author

We have discussed this in another PR and this change is already applied for the poll widget.

I am fine to have different ports for http/https. Just want to have the same config for all the widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants