Skip to content

Replace the old ImportWhiteboardDialog with a more generic and userfriendly import dialog #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MTRNord wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace the old ImportWhiteboardDialog with a more generic and userfriendly import dialog #848

MTRNord wants to merge 4 commits into from

Conversation

@MTRNord
Copy link
Contributor

@MTRNord MTRNord commented May 16, 2025 •
edited by Marcel-Nordeck
Loading

2025-05-16.15-10-06.webm

TODOs

  • Switch append vs replace(?) -> Maybe instead a checkbox?
  • Should also show up for drag and drop of pdf?

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 24b4f77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MTRNord MTRNord force-pushed the MTRNord/x/ImportOverhaul branch 2 times, most recently from 8b8ec14 to aae8947 Compare May 16, 2025 15:32
@MTRNord @Marcel-Nordeck
Replace the old ImportWhiteboardDialog with a more generic and userfr…
f3b528e 
…iendly import dialog

Signed-off-by: MTRNord <mtrnord1@gmail.com>
@Marcel-Nordeck Marcel-Nordeck self-assigned this Jun 14, 2025
@Marcel-Nordeck Marcel-Nordeck force-pushed the MTRNord/x/ImportOverhaul branch from aae8947 to 0cdf325 Compare June 14, 2025 10:18
@Marcel-Nordeck
Replace the radio buttons with a checkbox instead
b7945dd 
Signed-off-by: MTRNord <213429047+Marcel-Nordeck@users.noreply.github.com>
@Marcel-Nordeck Marcel-Nordeck force-pushed the MTRNord/x/ImportOverhaul branch from 0cdf325 to b7945dd Compare June 14, 2025 10:21
@Marcel-Nordeck
Fix the translation text for the checkbox subtext
5c40c09 
Signed-off-by: MTRNord <213429047+Marcel-Nordeck@users.noreply.github.com>
@Marcel-Nordeck
Show import dialog as well for pdf drag and drop
24b4f77 
Signed-off-by: MTRNord <213429047+Marcel-Nordeck@users.noreply.github.com>
@Marcel-Nordeck Marcel-Nordeck marked this pull request as ready for review June 14, 2025 11:11
@Marcel-Nordeck Marcel-Nordeck requested a review from a team as a code owner June 14, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Marcel-Nordeck Marcel-Nordeck

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MTRNord @Marcel-Nordeck