Skip to content

Conversation

@jaller94
Copy link
Contributor

@jaller94 jaller94 commented Mar 10, 2025

This document comes from a research spike about how to store formatted text in shapes.

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Signed-off-by: Christian Paul <christian.paul@nordeck.net>
@jaller94 jaller94 requested a review from a team as a code owner March 10, 2025 10:51
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 74f06e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jaller94 jaller94 changed the title Add ADR about text formatting Inline text formatting Mar 10, 2025
@jaller94 jaller94 changed the title Inline text formatting ADR: Text formatting Mar 10, 2025
Signed-off-by: Christian Paul <christian.paul@nordeck.net>
Signed-off-by: Christian Paul <christian.paul@nordeck.net>
@@ -0,0 +1,56 @@
# ADR009: Text formatting

Status: accepted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the current scope of research, I would say this should be draft instead. Once we implement it, then it can move to accepted.

}
```

This introduces a new property `textFormat` which is either missing or has the value `custom.text`. If it is missing, the property `text` contains plain text. If it has the value `custom.text`, it's expected to be the restricted subset of HTML described in this document.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All occurrences of custom.text should be changed to custom.html, right?


### Using `<b>`, `<em>` etc.

There is no tag which does the reverse, so
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sentence complete? If yes, I do not understand it. There is no tag which does the reverse of what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants