Prepare for using the extensions on Nordcraft#14
Merged
Conversation
erik-beus
requested changes
Apr 29, 2025
Contributor
erik-beus
left a comment
erik-beus
left a comment
There was a problem hiding this comment.
Looks good. Just a few suggestions
chrome/manifest.json
Outdated
| "description": "Browser extension for the toddle editor.", | ||
| "version": "2.3.3", | ||
| "name": "Nordcraft", | ||
| "description": "Browser extension for the nordcraft editor.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Browser extension for the nordcraft editor.", | |
| "description": "Browser extension for the Nordcraft editor.", |
LICENSE
Outdated
| MIT License | ||
|
|
||
| Copyright (c) 2024 toddledev | ||
| Copyright (c) 2024 nordcraft |
Contributor
There was a problem hiding this comment.
Suggested change
| Copyright (c) 2024 nordcraft | |
| Copyright (c) 2025 Nordcraft |
chrome/src/background.ts
Outdated
| import { updateSessionRules } from './helpers.js' | ||
|
|
||
| console.log('toddle extension loaded') | ||
| console.log('nordcraft extension loaded') |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log('nordcraft extension loaded') | |
| console.log('Nordcraft extension loaded') |
chrome/manifest.json
Outdated
| "type": "module" | ||
| }, | ||
| "homepage_url": "https://toddle.dev", | ||
| "homepage_url": "https://editor.nordcraft.com/", |
Contributor
There was a problem hiding this comment.
Suggested change
| "homepage_url": "https://editor.nordcraft.com/", | |
| "homepage_url": "https://nordcraft.com", |
firefox/manifest.json
Outdated
| "name": "Nordcraft", | ||
| "version": "2.3.2", | ||
| "description": "Browser extension for the toddle editor.", | ||
| "description": "Browser extension for the nordcraft editor.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Browser extension for the nordcraft editor.", | |
| "description": "Browser extension for the Nordcraft editor.", |
firefox/manifest.json
Outdated
| "homepage_url": "https://toddle.dev", | ||
| "permissions": ["cookies", "webRequest", "webRequestBlocking"], | ||
| "host_permissions": ["https://*.toddle.site/*"], | ||
| "homepage_url": "https://editor.nordcraft.com/", |
Contributor
There was a problem hiding this comment.
Suggested change
| "homepage_url": "https://editor.nordcraft.com/", | |
| "homepage_url": "https://nordcraft.com", |
firefox/src/background.ts
Outdated
| import('../../shared/setCookies.js').SetCookiesArguments | ||
|
|
||
| console.info('toddle extension loaded') | ||
| console.info('nordcraft extension loaded') |
Contributor
There was a problem hiding this comment.
Suggested change
| console.info('nordcraft extension loaded') | |
| console.info('Nordcraft extension loaded') |
firefox/src/background.ts
Outdated
|
|
||
| /** | ||
| * Used to send notifications to the toddle editor about which cookies are set | ||
| * Used to send notifications to the nordcraft editor about which cookies are set |
Contributor
There was a problem hiding this comment.
Suggested change
| * Used to send notifications to the nordcraft editor about which cookies are set | |
| * Used to send notifications to the Nordcraft editor about which cookies are set |
erik-beus
previously approved these changes
Apr 29, 2025
LICENSE
Outdated
| MIT License | ||
|
|
||
| Copyright (c) 2024 nordcraft | ||
| Copyright (c) 2024 Nordcraft |
Contributor
There was a problem hiding this comment.
Suggested change
| Copyright (c) 2024 Nordcraft | |
| Copyright (c) 2025 Nordcraft |
marija04
changed the title
|
We should launch this as a separate plugin right? So that people can have both installed at the same time. |
Contributor
Author
With this change we support both domains in the same extension. |
erik-beus
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.