Allow configuration for lowercase colors#88
Closed
FilippoBonazziSUSE wants to merge 1 commit intonorcalli:masterfrom
FilippoBonazziSUSE:lowercase_colors_option
Closed
Allow configuration for lowercase colors#88FilippoBonazziSUSE wants to merge 1 commit intonorcalli:masterfrom FilippoBonazziSUSE:lowercase_colors_option
FilippoBonazziSUSE wants to merge 1 commit intonorcalli:masterfrom
FilippoBonazziSUSE:lowercase_colors_option
Conversation
Unify COLOR_NAME_SETTINGS into DEFAULT_OPTIONS and allow users to specify a configuration value for 'lowercase' (and 'strip_digits' while we're at it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow configuration of lowercase color names with minimum changes to the current codebase.
Supersedes #77 (no need to change defaults), avoids the complicated changes in #18 (too much effort to adapt to current codebase).
@norcalli I believe this could be a simple fix which could unblock this feature.