Merged
Conversation
nootr
force-pushed
the
refactor/remove-rate-limiter-actor
branch
5 times, most recently
from
69117a6 to
aeed688
Compare
Remove the rate_limiter actor and unify in-memory and external store hit paths through a single Store interface. Store operations reduced from 4 (get/set/lock/unlock) to 3 (lock_and_get/set_and_unlock/unlock). In-memory mode uses no-op locks backed by the memory_store actor.
nootr
force-pushed
the
refactor/remove-rate-limiter-actor
branch
from
aeed688 to
abeeb82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rate_limiteractor — in-memory hits now go directly to thememory_storeactor (1 actor instead of 2), external store hits are plain function callsglimit.hit()andglimit.set_now()to the public APIbucket.compute_ttl()for store adapter authorsOptionfields with aStoreBackendsum type (MemoryBackend|ExternalBackend)glimit.new() |> glimit.per_second(10) |> ...) is unchangedTest plan
gleam buildsucceedsgleam test— 67 tests passgleam buildinexamples/redissucceedsglimit_rate_limiter_test.gleammerged intoglimit_test.gleam