Skip to content

Comments

Create LineHeightValue, model line-height-value/explicit#210

Merged
andrezero merged 2 commits intomainfrom
207-create-lineheightvalue-model-line-height-valueexplicit
Mar 9, 2025
Merged

Create LineHeightValue, model line-height-value/explicit#210
andrezero merged 2 commits intomainfrom
207-create-lineheightvalue-model-line-height-valueexplicit

Conversation

@andrezero
Copy link
Member

@andrezero andrezero commented Mar 9, 2025

@andrezero andrezero linked an issue Mar 9, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Mar 9, 2025

🐘 deployed to staging

Note: ⏳ Invalidating CDN cache may take up to 5 minutes

@github-actions
Copy link

github-actions bot commented Mar 9, 2025

🐘 deployed to staging

Note: ⏳ Invalidating CDN cache may take up to 5 minutes

return FONT_WEIGHT_FALLBACK_LITERAL;
}

// if (isLineHeightScaleDecision(decision)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-09 at 16 23 21

just noticed ☝️ FONT_WEIGHT 🤦

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and yep TODO, as well

@github-actions
Copy link

github-actions bot commented Mar 9, 2025

🐘 deployed to staging

Note: ⏳ Invalidating CDN cache may take up to 5 minutes

@andrezero andrezero merged commit 260b8c0 into main Mar 9, 2025
1 check passed
@andrezero andrezero deleted the 207-create-lineheightvalue-model-line-height-valueexplicit branch March 9, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create LineHeightValue, model line-height-value/explicit

2 participants