Skip to content

Fixes to popover behavior and builds#92

Merged
NikhilVerma merged 3 commits intomainfrom
popover-fix
Nov 1, 2025
Merged

Fixes to popover behavior and builds#92
NikhilVerma merged 3 commits intomainfrom
popover-fix

Conversation

@NikhilVerma
Copy link

This pull request introduces build system cleanup and improvements to the Storybook development environment, alongside dependency updates and some bug fixes in core UI components. The main themes are improved build configuration, better development ergonomics, and more robust popover/overlay handling.

Build and Development Environment Improvements:

  • Added source aliasing for local packages in Storybook's Vite config, enabling hot reload and easier development of core packages. (.storybook/main.ts)
  • Added a shared TypeScript config for Storybook and all core packages, standardizing build settings and declaration outputs. (.storybook/tsconfig.json, packages/flow-core/tsconfig.json, packages/flow-core-config/tsconfig.json, packages/flow-code-editor/tsconfig.json) [1] [2]
  • Added a clean target to the Makefile for cleaning build artifacts and resetting the repo. (Makefile)

Dependency and Package Updates:

  • Updated local package dependencies to latest patch versions, and fixed type/module field outputs for consistency. (package.json, packages/flow-core/package.json, packages/flow-core-config/package.json, packages/flow-code-editor/package.json, packages/flow-dashboard/package.json) [1] [2] [3] [4] [5] [6]
  • Updated changelogs to reflect build cleanup and dependency bumps. (CHANGELOG.md files) [1] [2] [3] [4]

Popover and Overlay Bug Fixes:

  • Improved overlay click handling for FPopover, FColorPicker, and FEmojiPicker components to ensure overlays are properly interactive and close as expected. (packages/flow-core/src/components/f-popover/f-popover.ts, packages/flow-core/src/components/f-color-picker/f-color-picker.ts, packages/flow-core/src/components/f-emoji-picker/f-emoji-picker.ts) [1] [2] [3] [4] [5] [6]
  • Changed event listeners in FPopover to use the capture phase for more reliable outside click detection. (packages/flow-core/src/components/f-popover/f-popover.ts) [1] [2]

Import Path Fixes:

  • Updated imports in Storybook preview and test files to use new source aliasing and correct package entry points. (.storybook/preview.ts, packages/flow-core/src/components/f-icon/f-icon.test.ts) [1] [2]

Let me know if you want to dive deeper into any specific change!

@NikhilVerma NikhilVerma merged commit 4bd5b9c into main Nov 1, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant