Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces build system cleanup and improvements to the Storybook development environment, alongside dependency updates and some bug fixes in core UI components. The main themes are improved build configuration, better development ergonomics, and more robust popover/overlay handling.
Build and Development Environment Improvements:
.storybook/main.ts).storybook/tsconfig.json,packages/flow-core/tsconfig.json,packages/flow-core-config/tsconfig.json,packages/flow-code-editor/tsconfig.json) [1] [2]cleantarget to the Makefile for cleaning build artifacts and resetting the repo. (Makefile)Dependency and Package Updates:
package.json,packages/flow-core/package.json,packages/flow-core-config/package.json,packages/flow-code-editor/package.json,packages/flow-dashboard/package.json) [1] [2] [3] [4] [5] [6]CHANGELOG.mdfiles) [1] [2] [3] [4]Popover and Overlay Bug Fixes:
FPopover,FColorPicker, andFEmojiPickercomponents to ensure overlays are properly interactive and close as expected. (packages/flow-core/src/components/f-popover/f-popover.ts,packages/flow-core/src/components/f-color-picker/f-color-picker.ts,packages/flow-core/src/components/f-emoji-picker/f-emoji-picker.ts) [1] [2] [3] [4] [5] [6]FPopoverto use the capture phase for more reliable outside click detection. (packages/flow-core/src/components/f-popover/f-popover.ts) [1] [2]Import Path Fixes:
.storybook/preview.ts,packages/flow-core/src/components/f-icon/f-icon.test.ts) [1] [2]Let me know if you want to dive deeper into any specific change!