Extract behavior ledger append helper#146
Open
scottscott wants to merge 1 commit intonomoticai:mainfrom
Open
Conversation
Refactor GovernanceRuntime._record_verdict by moving BehaviorLedger entry construction and append logic into _append_behavior_ledger_entry. Adds focused tests for default thresholds, derived thresholds, and no-op behavior when ledgering is disabled. assisted-by: GitHub Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sixth runtime decomposition implementation slice: extract BehaviorLedger append flow from
_record_verdict.Key Changes
GovernanceRuntime._append_behavior_ledger_entry(action, context, verdict, tracer, derived_thresholds)insrc/nomotic/runtime.py._record_verdict(...)with a helper call.Test Updates
tests/test_runtime.py:test_append_behavior_ledger_entry_uses_default_thresholdstest_append_behavior_ledger_entry_uses_derived_thresholdstest_append_behavior_ledger_entry_noop_without_ledger_or_tracerValidation
pytest -q tests/test_runtime.py tests/test_contract.py->49 passedScope