Extract lifecycle state classification helpers#142
Open
scottscott wants to merge 2 commits intonomoticai:mainfrom
Open
Extract lifecycle state classification helpers#142scottscott wants to merge 2 commits intonomoticai:mainfrom
scottscott wants to merge 2 commits intonomoticai:mainfrom
Conversation
Refactor lifecycle transition checks in GovernanceRuntime by extracting UAHS health lookup, state classification, and event mapping helpers. Keeps behavior unchanged while making transition logic easier to evolve in subsequent decomposition slices. assisted-by: GitHub Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add focused lifecycle tests for missing UAHS score handling and unknown lifecycle state mapping to improve diff coverage on PR nomoticai#142. assisted-by: GitHub Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second runtime decomposition implementation slice: extract lifecycle transition decision helpers.
Key Changes
src/nomotic/runtime.py:_get_uahs_health(agent_id)_classify_lifecycle_state(trust, uahs)_lifecycle_event_for_state(state)_check_lifecycle_transitions(...)to orchestrate transition flow using these helpers.Test Updates
tests/test_lifecycle.py:Validation
pytest -q tests/test_lifecycle.py tests/test_runtime.py->52 passedScope