Close remaining mcp_proxy coverage gaps#139
Merged
scottscott merged 3 commits intonomoticai:mainfrom Mar 20, 2026
Merged
Conversation
Add targeted HTTP run-path tests for certificate-required POST handling, allowed tool-call forwarding, bytes/str response serialization, debug request logging, and shutdown signal timer behavior. Raises nomotic.mcp_proxy coverage to 100% in test_mcp_proxy run. assisted-by: GitHub Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add retry logic for HTTP integration helper requests in TestMCPHTTPGovernanceProxyRunIntegration to handle rare macOS CI ConnectionResetError/BrokenPipeError race conditions. Keeps assertions unchanged while reducing nondeterministic failures. assisted-by: GitHub Copilot
Avoid flaky body-read socket reset behavior on macOS by using status-only request assertions for certificate-required integration paths, while preserving branch coverage and certificate verification assertions. assisted-by: GitHub Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged PR #138: close the remaining
nomotic.mcp_proxycoverage gaps with focused HTTP run-path tests.Key Changes
tests/test_mcp_proxy.pyfor:bytesandstrbodieslog_messagebranch_shutting_down+ timer start)Validation
pytest -q tests/test_mcp_proxy.py --cov=nomotic.mcp_proxy --cov-report=term-missing:skip-covered79 passednomotic.mcp_proxy:100%coverage in this targeted runNotes