Skip API tests when fastapi is not installed#1
Merged
Conversation
fastapi is an optional dependency (agentpk[api]), so test_api.py should gracefully skip instead of failing with an ImportError during collection. https://claude.ai/code/session_01TxNcxsPV2QXDc71e15dLV1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the test suite to gracefully skip API tests when the optional
fastapidependency is not installed, rather than failing with an import error.Key Changes
pytest.importorskip()call for thefastapimodule before importing from it[api]extra will no longer see test failures for missing optional dependenciesImplementation Details
The
pytest.importorskip()function is used to conditionally skip the entire test module if fastapi is not installed. The skip message directs users to install the package with the[api]extra:pip install agentpk[api]. This is a best practice for handling optional test dependencies in pytest.