bug fix: check pending learner before promote in rule checker #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jyz0309 <45495947@qq.com>
…#3016) Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
* pdctl: add state filter support in store command Signed-off-by: Zheming Li <nkdudu@126.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: longfangsong <longfangsong@icloud.com>
…s metrics (tikv#3031) Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch
reviewed
Oct 10, 2020
|
|
||
| // CreatePromoteLearnerOperator creates an operator that promotes a learner. | ||
| func CreatePromoteLearnerOperator(desc string, cluster opt.Cluster, region *core.RegionInfo, peer *metapb.Peer) (*Operator, error) { | ||
| if region.GetPendingPeer(peer.GetId()) != nil { |
Owner
There was a problem hiding this comment.
This check is more reasonable in the builder.
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: ZenoTan <zenotan1998@gmail.com>
Signed-off-by: ZenoTan <zenotan1998@gmail.com>
Signed-off-by: Zheming Li <nkdudu@126.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: ZenoTan <zenotan1998@gmail.com>
Signed-off-by: ZenoTan <zenotan1998@gmail.com>
Signed-off-by: ZenoTan <zenotan1998@gmail.com>
nolouch
pushed a commit
that referenced
this pull request
Dec 30, 2022
server: Add `approixmateKvSize` fro `RegionInfo` to use for TiDB ratelimit
nolouch
pushed a commit
that referenced
this pull request
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ZenoTan zenotan1998@gmail.com
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes